Use hosts deployed from director as url parameters in CubeLinks #2438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case there were none of the hosts showed in a dimension for the cube module, then do not show the CubeLinks for that dimension.
Thomas-Gelf
requested changes
Nov 24, 2021
| @@ -19,6 +22,8 @@ public function prepareActionLinks(Cube $cube, View $view) | |||
| return; | |||
| } | |||
|
|
|||
| $directorHosts = array_keys(IcingaObject::loadAllByType('Host', $this->directorDb())); | |||
There was a problem hiding this comment.
This is not a good idea, loading all Hosts is not an option. While the user might select just a bunch of them, the DB can easily contain 100k+.
There was a problem hiding this comment.
That's already the case here: https://github.com/Icinga/icingaweb2-module-director/pull/2436/files#diff-37cfa9169f450b93bda4663c3e82742f0d45336115ae2394ab9c831cab184be9R29, Just FYI
There was a problem hiding this comment.
@nilmerg: thanks for pointing this out, I overlooked it! @raviks789: please either use the deployment location in IcingaDB as a source of truth or ask the Director about the selected hosts only. If unsure how to address this, please let me know
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case there were none of the hosts showed in a dimension for the cube module, then do not show the CubeLinks for that dimension.
fixes #2437